linux-kernel - Re: [PATCH 3/3] ia64: Call migration code on correctable errors v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 9 May 2008 14:03:19 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Russ Anderson <rja@....com>
cc:	linux-kernel@...r.kernel.org, linux-ia64@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH 3/3] ia64: Call migration code on correctable errors v3

On Fri, 9 May 2008, Russ Anderson wrote:

> +	local_irq_save(irq_flags);

The page migration functions expect to be called in non atomic contexts 
since they use things like lock_page(). Can you just drop the irq disable? 
The spinlock should not be there either. Page migration serialize via 
the LRU. Pages that are to be migrated have to be taken off the LRU 
first. There is no danger of two threads trying to migrate the same 
page because the second one will not be able to take it off the LRU 
anymore.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/