linux-kernel - Re: [PATCH] Silence 'ignoring return value' warnings in drivers/video/aty/radeon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080509073348.7045656f@gondolin.boeblingen.de.ibm.com>
Date:	Fri, 9 May 2008 07:33:48 +0200
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Paul Mackerras <paulus@...ba.org>, Greg KH <greg@...ah.com>,
	benh@...nel.crashing.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>, tony@...eyournoodle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Silence 'ignoring return value' warnings in
 drivers/video/aty/radeon_base.c

On Thu, 08 May 2008 17:02:44 -0700,
Harvey Harrison <harvey.harrison@...il.com> wrote:

> On Fri, 2008-05-09 at 09:50 +1000, Paul Mackerras wrote:
> > I think the best solution is to make a new sysfs_maybe_create_file()
> > which isn't marked must_check, and then move suitable callers (such as
> > radeonfb) over to that.  That will make it obvious in the callers that
> > the file creation isn't guaranteed.

Either that...

> 
> Or just a a flag parameter to the existing one that says whether failure
> is allowed or not.  In a case that fails, a WARN_ON can be printed from
> the common create_file rather than putting printks all over the kernel.

...or that. But the core should still warn about duplicate files in all
cases, since that indicates a bug. (And that will catch the problems we
found before; IIRC a core warning didn't exist back then.)

> 
> This would also document which files are necessary vs. optional.

Shouldn't that rather go into Documentation/ABI/, so that people can
easily find out what they may rely on?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/