linux-kernel - Re: regression fixed by using pci=rom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200805082329.39987.jbarnes@virtuousgeek.org>
Date:	Thu, 8 May 2008 23:29:39 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Dave Airlie <airlied@...il.com>,
	kernel list <linux-kernel@...r.kernel.org>,
	Gary Hade <garyhade@...ibm.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: regression fixed by using pci=rom

On Thursday, May 08, 2008 6:46 pm Linus Torvalds wrote:
> On Thu, 8 May 2008, Jesse Barnes wrote:
> > Hm, yeah in many cases we definitely *do* want to try to get the
> > expansion ROM space allocated.  But maybe it should be a lower priority
> > than other BARs... Gary?
>
> The thing is, a lot of these things have been done this way because not
> doing them that way breaks.
>
> We want to allocate expansion ROM space - even if we don't enable it -
> because not doing so will screw up bus sizing etc, and can make it
> impossible to allocate later.
>
> In general, changing PCI allocation strategy is really _really_ dangerous,
> even when it is "right", because it tends to expose a lot of issues where
> something worked just because it was perhaps indirectly causing a layout
> that worked.

Yeah, that was my first impression too, but the patch went upstream awhile ago 
and I didn't see any background except for the changelog.

If anything, we should have a pci=norom option instead, so that big systems 
that don't need the ROMs can use their address space more efficiently.

Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/