linux-kernel - [PATCH] /fs/partition/check.c: fix return value warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 10 May 2008 13:40:53 +0200
From:	Abdel Benamrouche <draconux@...il.com>
To:	aeb@....nl
Cc:	linux-kernel@...r.kernel.org, trivial@...nel.org,
	Abdel Benamrouche <draconux@...il.com>
Subject: [PATCH] /fs/partition/check.c: fix return value warning

fs/partitions/check.c:381: warning: ignoring return value of ‘device_add’,
 declared with attribute warn_unused_result

Signed-off-by: Abdel Benamrouche <draconux@...il.com>
---
:100644 100644 6149e4b... 7a87fad... M	fs/partitions/check.c
 fs/partitions/check.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/fs/partitions/check.c b/fs/partitions/check.c
index 6149e4b..7a87fad 100644
--- a/fs/partitions/check.c
+++ b/fs/partitions/check.c
@@ -378,7 +378,13 @@ void add_partition(struct gendisk *disk, int part, sector_t start, sector_t len,
 
 	/* delay uevent until 'holders' subdir is created */
 	p->dev.uevent_suppress = 1;
-	device_add(&p->dev);
+	if (device_add(&p->dev)) {
+		put_device(&p->dev);
+		free_part_stats(p);
+		kfree(p);
+		return;
+	}
+
 	partition_sysfs_add_subdir(p);
 	p->dev.uevent_suppress = 0;
 	if (flags & ADDPART_FLAG_WHOLEDISK)
-- 
1.5.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/