linux-kernel - Re: 2.6.26-rc1 on x86: ld: warning: dot moved backwards before `.text'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 11 May 2008 22:24:40 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Sam Ravnborg <sam@...nborg.org>,
	Mikael Pettersson <mikpe@...uu.se>,
	Pavel Machek <pavel@....cz>, "Rafael J. Wysocki" <rjw@...k.pl>,
	tglx@...utronix.de, mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: 2.6.26-rc1 on x86: ld: warning: dot moved backwards before
	`.text'

[H. Peter Anvin - Sun, May 11, 2008 at 11:15:04AM -0700]
> Cyrill Gorcunov wrote:
>> Should not it be something like
>> ---
>> diff --git a/arch/x86/kernel/acpi/realmode/wakeup.lds.S 
>> b/arch/x86/kernel/acpi/realmode/wakeup.lds.S
>> index 22fab6c..cccf62d 100644
>> --- a/arch/x86/kernel/acpi/realmode/wakeup.lds.S
>> +++ b/arch/x86/kernel/acpi/realmode/wakeup.lds.S
>> @@ -12,11 +12,6 @@ ENTRY(_start)
>>   SECTIONS
>>  {
>> -	. = HEADER_OFFSET;
>> -	.header : {
>> -		 *(.header)
>> -	}
>> -
>>  	. = 0;
>>  	.text : {
>>  		 *(.text*)
>> @@ -53,6 +48,11 @@ SECTIONS
>>  	. = ALIGN(16);
>>  	_end = .;
>>  +	. = HEADER_OFFSET;
>> +	.header : {
>> +		 *(.header)
>> +	}
>> +
>>  	/DISCARD/ : {
>>  		*(.note*)
>>  	}
>> ---
>> 		- Cyrill -
>
> Yes.  This was the way I originally had it, then Pavel decided to move the 
> header to the end.
>
> 	-hpa
>

Hi Peter,

actually I only doubt about exactly position of this headers - I mean
meguess it better should be _before_ "_end" not after. Since the others
script uses (acpi/wakeup_rm.S):

	wakeup_code_start:
	.incbin	"arch/x86/kernel/acpi/realmode/wakeup.bin"
	wakeup_code_end:

and kernel uses these wakeup_code_* marks to save/restore memory I think
it should be like

	. = HEADER_OFFSET;
	.header : {
		...
	}
	. = ALIGN(16);
	_end = .;
	/DISCARD/ ...

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/