linux-kernel - [PATCH] jfs: 0 is not valid errno value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080511200842.GN19058@joi>
Date:	Sun, 11 May 2008 22:08:45 +0200
From:	Marcin Slusarz <marcin.slusarz@...il.com>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	Dave Kleikamp <shaggy@...tin.ibm.com>,
	jfs-discussion@...ts.sourceforge.net,
	Alexander Viro <viro@...iv.linux.org.uk>
Subject: [PATCH] jfs: 0 is not valid errno value

... so return NULL from jfs_lookup

Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>
Cc: Dave Kleikamp <shaggy@...tin.ibm.com>
Cc: jfs-discussion@...ts.sourceforge.net
Cc: Alexander Viro <viro@...iv.linux.org.uk>
---
is it ok to return NULL from this function?
compile tested only
---
 fs/jfs/namei.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c
--- a/fs/jfs/namei.c
+++ b/fs/jfs/namei.c
@@ -1455,7 +1455,7 @@ static struct dentry *jfs_lookup(struct inode *dip, struct dentry *dentry, struc
 		free_UCSname(&key);
 		if (rc == -ENOENT) {
 			d_add(dentry, NULL);
-			return ERR_PTR(0);
+			return NULL;
 		} else if (rc) {
 			jfs_err("jfs_lookup: dtSearch returned %d", rc);
 			return ERR_PTR(rc);
-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/