linux-kernel - Re: [PATCH] isdn/capi: return proper errnos on module init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080511212117.GB1641@uranus.ravnborg.org>
Date:	Sun, 11 May 2008 23:21:17 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Marcin Slusarz <marcin.slusarz@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] isdn/capi: return proper errnos on module init

On Sun, May 11, 2008 at 11:07:07PM +0200, Karsten Keil wrote:
> cdebug_init is called from kcapi_init which is module initialization function,
> so it must return negative values on errors
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>
> Acked-by: Karsten Keil <kkeil@...e.de>

Hi Karsten.

Lately David Miller has started to include isdn patches
in his netdev tree. So I think you should pass then on to David
and not Andrew.
David or Andrew will correct me if I'm wrong...

	Sam

> ---
> compile tested only
> ---
>  drivers/isdn/capi/capiutil.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/isdn/capi/capiutil.c b/drivers/isdn/capi/capiutil.c
> --- a/drivers/isdn/capi/capiutil.c
> +++ b/drivers/isdn/capi/capiutil.c
> @@ -948,17 +948,17 @@ int __init cdebug_init(void)
>  {
>  	g_cmsg= kmalloc(sizeof(_cmsg), GFP_KERNEL);
>  	if (!g_cmsg)
> -		return ENOMEM;
> +		return -ENOMEM;
>  	g_debbuf = kmalloc(sizeof(_cdebbuf), GFP_KERNEL);
>  	if (!g_debbuf) {
>  		kfree(g_cmsg);
> -		return ENOMEM;
> +		return -ENOMEM;
>  	}
>  	g_debbuf->buf = kmalloc(CDEBUG_GSIZE, GFP_KERNEL);
>  	if (!g_debbuf->buf) {
>  		kfree(g_cmsg);
>  		kfree(g_debbuf);
> -		return ENOMEM;;
> +		return -ENOMEM;;
>  	}
>  	g_debbuf->size = CDEBUG_GSIZE;
>  	g_debbuf->buf[0] = 0;
> -- 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/