linux-kernel - better msleep for drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 11 May 2008 13:01:24 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	tglx@...utronix.de
Cc:	linux-kernel@...r.kernel.org
Subject: better msleep for drivers

Thomas,

Someone asked if there is a msleep using hrtimers that is more accurate
than jiffies/msecs for external drivers. There is hrtimer nanosleep,
but it is currently not exported. It can be reimplemented using hrtimer_start
etc. which are exported, but that seems rather clumpsy.

Is there any reason such an obvious function is not exported? 

Ok I guess right now nobody in tree is using it. But that seems wrong.  
Perhaps we should have a (exported) usleep_blocking() wrapper or somesuch for 
that case?  

I suspect that a lot of drivers could make use of it. Just from grepping we 
have a lot of msleep(1)s in drivers and I suspect a lot of those would 
actually like to delay shorter than one jiffie. 

One argument against it would be that it makes them more difficult to test 
because behavior will differ between hrtimer enabled and disabled systems. 
Still longer term I suppose there's really no way around having accurate
sleep functions and it's probably better to start testing earlier than later.

Thoughts?

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/