linux-kernel - Re: [PATCH 08/56] microblaze_v2: Interrupt handling, timer support, supported function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0805111630001.3197@apollo.tec.linutronix.de>
Date:	Sun, 11 May 2008 16:35:21 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Michal Simek <monstr@...nam.cz>
cc:	linux-kernel@...r.kernel.org, arnd@...db.de,
	linux-arch@...r.kernel.org, stephen.neuendorffer@...inx.com,
	John.Linn@...inx.com, john.williams@...alogix.com, matthew@....cx,
	will.newton@...il.com, drepper@...hat.com,
	microblaze-uclinux@...e.uq.edu.au, grant.likely@...retlab.ca,
	Michal Simek <monstr@...str.eu>
Subject: Re: [PATCH 08/56] microblaze_v2: Interrupt handling, timer support,
 supported function

Michal,

On Sun, 11 May 2008, Michal Simek wrote:
> > 
> > Please split this modification code out into a separate function. The
> > same code is used below.
> 
> Add Macro.

Please use a (inline) function whenever possible. Macros are harder to
read and not type safe.

> > Can you please move a new architecture to clockevents / clocksource
> > right from the beginning ? No need to invent another incompatible set
> > of time(r) related functions.
> 
> I move whole code to GENERIC_TIME. Did you meant any others changes?

GENERIC_TIME and GENERIC_CLOCKEVENTS. You get high resolution timers
and dynamic ticks for free when your timer hardware allows it.

> >> +#define NO_IRQ (-1)
> >> +
> >> +static inline int irq_canonicalize(int irq)
> >> +{
> >> +	return (irq);
> >> +}
> > 
> > Why is this needed ? Any users ?
> 
> is used in serial_core.c
>  684         new_serial.irq = irq_canonicalize(new_serial.irq);

Doh, forgot about that one.

Thanks,
	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/