linux-kernel - [PATCH] [RFC] shrink struct pid by removing padding on 64 bit builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1210519776.2958.34.camel@castor.localdomain>
Date:	Sun, 11 May 2008 16:29:36 +0100
From:	Richard Kennedy <richard@....demon.co.uk>
To:	lkml <linux-kernel@...r.kernel.org>
Subject: [PATCH] [RFC] shrink struct pid by removing padding on 64 bit
	builds

When struct pid is built on a 64 bit platform gcc has to insert padding
to maintain the correct alignment, by simply reordering its members the
memory usage shrinks from 88 bytes to 80.

I've successfully run with this patch on my desktop AMD64 machine.

There are no significant kernel size changes to a default config.X86_64
on the latest git v2.6.26-rc1

   text    data     bss     dec     hex filename
5404828  976760  734280 7115868  6c945c vmlinux
5404811  976760  734280 7115851  6c944b vmlinux.pid-patch

The question really is : Is it safe to make this change?

I haven't spotted anywhere that depends on the exact layout of the pid
structure, but there's a lot of code to review & I haven't gone though
it all in detail.
struct pid doesn't appear in the user headers, so isn't exposed to user
space. So I think it will be safe.

Any ideas ?

Thanks
Richard

diff --git a/include/linux/pid.h b/include/linux/pid.h
index c21c7e8..6f084b9 100644
--- a/include/linux/pid.h
+++ b/include/linux/pid.h
@@ -57,10 +57,10 @@ struct upid {
 struct pid
 {
 	atomic_t count;
+	unsigned int level;
 	/* lists of tasks that use this pid */
 	struct hlist_head tasks[PIDTYPE_MAX];
 	struct rcu_head rcu;
-	unsigned int level;
 	struct upid numbers[1];
 };

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/