linux-kernel - [patch, 2.6.26-rc2] dvb: drivers/media/dvb/ttpci/fdump firmware build error fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080512101231.GA11755@elte.hu>
Date:	Mon, 12 May 2008 12:12:31 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	linux-kernel@...r.kernel.org
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Oliver Endriss <o.endriss@....de>,
	Andrew de Quincey <adq_dvb@...skialf.net>,
	Johannes Stezenbach <js@...uxtv.org>
Subject: [patch, 2.6.26-rc2] dvb: drivers/media/dvb/ttpci/fdump firmware
	build error fix


x86.git testing found the following build failure in 2.6.26-rc2:

  drivers/media/dvb/ttpci/fdump "/usr/lib/hotplug/firmware/dvb-ttpci-01.fw" dvb_ttpci_fw drivers/media/dvb/ttpci/av7110_firm.h
  firmware file '/usr/lib/hotplug/firmware/dvb-ttpci-01.fw' not found
  make[4]: *** [drivers/media/dvb/ttpci/av7110_firm.h] Error 255
  make[3]: *** [drivers/media/dvb/ttpci] Error 2

in this config:

  http://redhat.com/~mingo/misc/config-Mon_May_12_11_29_29_CEST_2008.bad

the reason for the build bug is that the driver's Kconfig ignores the 
PREVENT_FIRMWARE_BUILD=y config setting and tries to build the firmware 
which (like other firmware build methods) relies on a non-upstream 
firmware blob. The fix is to make the firmware build depend on 
!PREVENT_FIRMWARE_BUILD.

Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 drivers/media/dvb/ttpci/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/media/dvb/ttpci/Kconfig
===================================================================
--- linux.orig/drivers/media/dvb/ttpci/Kconfig
+++ linux/drivers/media/dvb/ttpci/Kconfig
@@ -33,7 +33,7 @@ config DVB_AV7110
 
 config DVB_AV7110_FIRMWARE
 	bool "Compile AV7110 firmware into the driver"
-	depends on DVB_AV7110 && !STANDALONE
+	depends on DVB_AV7110 && !STANDALONE && !PREVENT_FIRMWARE_BUILD
 	default y if DVB_AV7110=y
 	help
 	  The AV7110 firmware is normally loaded by the firmware hotplug manager.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/