linux-kernel - Re: [RFC/PATCH] printk: detect incomplete lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020805120456r14436eend416e079ea88be9c@mail.gmail.com>
Date:	Mon, 12 May 2008 14:56:28 +0300
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Vegard Nossum" <vegard.nossum@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Rob Landley" <rob@...dley.net>
Subject: Re: [RFC/PATCH] printk: detect incomplete lines

On Mon, May 12, 2008 at 2:49 PM, Vegard Nossum <vegard.nossum@...il.com> wrote:
>  This printk() problem has been bugging me for a long time. Consider the
>  following code:
>
>  diff --git a/init/main.c b/init/main.c
>  index ddada7a..777e02d 100644
>  --- a/init/main.c
>  +++ b/init/main.c
>  @@ -452,17 +452,38 @@ static void __init setup_command_line(char *command_line)
>   * gcc-3.4 accidentally inlines this function, so use noinline.
>   */
>
>  +static void printk_thread(const char *msg, unsigned long wait)
>  +{
>  +       int i = 0;
>  +
>  +       while(true) {
>  +               if (i == 0)
>  +                       printk(KERN_INFO "Here we go: ");
>  +
>  +               printk("%s%s", msg, i < 7 ? ", " : "\n");

You are supposed to use KERN_CONT here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/