linux-kernel - Re: [PATCH 1/1] [INPUT/KEYPAD] gpio keypad: Replace current blackfin specific pfbutton driver with kernel generic gpio key driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200805120955.53380.david-b@pacbell.net>
Date:	Mon, 12 May 2008 09:55:52 -0700
From:	David Brownell <david-b@...bell.net>
To:	Bryan Wu <cooloney@...nel.org>
Cc:	dbrownell@...rs.sourceforge.net, dmitry.torokhov@...il.com,
	philipp.zabel@...il.com, linux-kernel@...r.kernel.org,
	Michael Hennerich <michael.hennerich@...log.com>
Subject: Re: [PATCH 1/1] [INPUT/KEYPAD] gpio keypad: Replace current blackfin specific pfbutton driver with kernel generic gpio key driver

On Monday 12 May 2008, Bryan Wu wrote:
>                         unsigned int type = button->type ?: EV_KEY;
> +                       GPIOKEYS_EDGE_SENSE(0);
>                         int state = (gpio_get_value(gpio) ? 1 : 0) ^ button->active_low;
> -
> +                       GPIOKEYS_EDGE_SENSE(1);

By the way ... don't intersperse declarations like "int state"
with code like what those EDGE_SENSE macros wraps...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/