lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 May 2008 11:51:51 +0800 From: WANG Cong <xiyou.wangcong@...il.com> To: Al Viro <viro@...IV.linux.org.uk> Cc: WANG Cong <xiyou.wangcong@...il.com>, LKML <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...l.org>, WANG Cong <wangcong@...ux.org> Subject: Re: [Patch 9/9] fs/exec.c: fix a wrong goto path On Sat, May 10, 2008 at 08:37:01PM +0100, Al Viro wrote: >On Thu, May 08, 2008 at 09:52:34PM +0800, WANG Cong wrote: >> When nameidata_to_filp() fails, I see no reasons to fall into 'out' path >> where doesn't free any resources at all. > >How about "nameidata_to_filp() frees on failure"? When it fails, it should free the resources that were allocated before it. That's to say, it should goto 'exit' on failure. Am I missing something obvious? -- Hi, I'm a .signature virus, please copy/paste me to help me spread all over the world. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists