linux-kernel - Re: [PATCH 1/2] [8250 Serial Driver]: Added support for 8250-class UARTs in HV Sistemas H8606 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48287EFB.3070303@hvsistemas.es>
Date:	Mon, 12 May 2008 19:31:39 +0200
From:	Javier Herrero <jherrero@...istemas.es>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	Bryan Wu <cooloney@...nel.org>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, Bryan Wu <bryan.wu@...log.com>
Subject: Re: [PATCH 1/2] [8250 Serial Driver]: Added support for 8250-class
 UARTs in HV Sistemas H8606 board

Hello, Alan,

Thans, I will redo the patch in the way you suggest, test it and resend.

Regards,

Javier

Alan Cox escribió:
>>  
>> +#ifdef SERIAL_EXTRA_IRQ_FLAGS
>> +		irq_flags |= SERIAL_EXTRA_IRQ_FLAGS;
>> +#endif
>> +
>
>
> We try and keep ifdefs out of code. It is also not clear what you would
> do if you had a box where the extra flags depended on the port.
>
> So two suggestions
>
> Either
>
> Add just the line
>
> +		irq_flags |= SERIAL_EXTRA_IRQ_FLAGS;
>
> and at the end of 8250.h do
>
> #ifndef SERIAL_EXTRA_IRQ_FLAGS
> #define SERIAL_EXTRA_IRQ_FLAGS			0
> #endif
>
> or the same but with an argument (unused for now)
>
> SERIAL_EXTRA_IRQ_FLAGS(up)
>
> Alan
>
>

-- 
------------------------------------------------------------------------
Javier Herrero                            EMAIL: jherrero@...istemas.com
HV Sistemas S.L.                          PHONE:         +34 949 336 806
Los Charcones, 17A                        FAX:           +34 949 336 792
19170 El Casar - Guadalajara - Spain      WEB: http://www.hvsistemas.com 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/