linux-kernel - Re: [PATCH] riscom8: remove redundant null pointer test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080512205823.23adc6f1@core>
Date:	Mon, 12 May 2008 20:58:23 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Chris Malley <mail@...ismalley.co.uk>
Cc:	Alan Cox <alan@...hat.com>, linux-kernel@...r.kernel.org,
	akpm@...l.org
Subject: Re: [PATCH] riscom8: remove redundant null pointer test

On Mon, 12 May 2008 19:27:10 +0100
Chris Malley <mail@...ismalley.co.uk> wrote:

> tty has already been dereferenced at least twice in these functions,
> so checking for null here seems a bit unnecessary.

Oh it is - and lots of the other tty checks are bogus too.

Acked-by: Alan Cox <alan@...hat.com>

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/