linux-kernel - request_firmware() gives build failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <17728.1210628903@vena.lwn.net>
Date:	Mon, 12 May 2008 15:48:23 -0600
From:	Jonathan Corbet <corbet@....net>
To:	linux-kernel@...r.kernel.org
Subject: request_firmware() gives build failures

Just tried building -rc2 (then current git) and got a few errors like:

  drivers/built-in.o: In function `generic_set_freq':
  tuner-xc2028.c:(.text+0x90f42): undefined reference to `request_firmware'
  tuner-xc2028.c:(.text+0x91418): undefined reference to `release_firmware'

A bit of digging turned up the problem: I had fw_loader configured as a
module, but some drivers which need it were configured built-in.  Don't
ask why I had those drivers configured in at all...time to prune that
.config I've been carrying around...

In any case, setting CONFIG_FW_LOADER=y makes the problem go away.  I'm
not good enough at kconfig to make that happen magically; putting in
"select FW_LOADER" doesn't seem to be enough.  In any case, given that
callers to request_firmware() can be built in, does it make sense to
have an option to make the firmware loader modular?

jon

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/