linux-kernel - Re: [PATCH 1/1] avr32/pata: avoid unnecessary memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4828C86C.7010007@atmel.com>
Date:	Tue, 13 May 2008 00:45:00 +0200
From:	Haavard Skinnemoen 
	<haavard.skinnemoen@...el.com>
To:	Christophe Jaillet <christophe.jaillet@...adoo.fr>
CC:	linux <linux-kernel@...r.kernel.org>,
	Kristoffer Nyborg Gregertsen <gregerts@...d.ntnu.no>,
	Jeff Garzik <jeff@...zik.org>
Subject: Re: [PATCH 1/1] avr32/pata: avoid unnecessary memset

Christophe Jaillet wrote:
> From: Christophe Jaillet <christophe.jaillet@...adoo.fr>
> 
> Hi, here is a patch against linux/drivers/dma/iop-adma.c which :

Hmm...no, it's for drivers/ata/pata_at32.c.

> 1) Remove an explicit memset(.., 0, ...) to a variable allocated with
> kzalloc (i.e. 'info').
> 
> 
> Note: this patch is based on 'linux-2.6.25.tar.bz2'
> 
> Signed-off-by: Christophe Jaillet <christophe.jaillet@...adoo.fr>

Other than that, it looks good to me. Could you please fix the patch 
description, add

Acked-by: Haavard Skinnemoen <haavard.skinnemoen@...el.com>

and send it to Jeff?

Thanks a lot!

Haavard

> ---
> 
> --- linux/drivers/ata/pata_at32.c	2008-04-17 04:49:44.000000000 +0200
> +++ linux/drivers/ata/pata_at32.c.cj	2008-05-12 23:07:10.000000000 +0200
> @@ -329,8 +329,6 @@ static int __init pata_at32_probe(struct
>  	if (!info)
>  		return -ENOMEM;
>  
> -	memset(info, 0, sizeof(struct at32_ide_info));
> -
>  	info->irq = irq;
>  	info->cs  = board->cs;
>  
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/