linux-kernel - Re: [PATCH] net/sunrpc/xprtrdma: fix svc_rdma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080512012022.GA27353@fieldses.org>
Date:	Sun, 11 May 2008 21:20:22 -0400
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	Marcin Slusarz <marcin.slusarz@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Tom Tucker <tom@...ngridcomputing.com>
Subject: Re: [PATCH] net/sunrpc/xprtrdma: fix svc_rdma_create out of memory
	error path

Thanks!  But I think Tom is just doing some final revisions on a patch
series that already includes this fix?

--b.

On Sun, May 11, 2008 at 10:07:25PM +0200, Marcin Slusarz wrote:
> ERR_PTR takes negative errno as a parameter
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>
> Cc: Tom Tucker <tom@...ngridcomputing.com>
> Cc: J. Bruce Fields <bfields@...i.umich.edu>
> ---
> compile tested only
> ---
>  net/sunrpc/xprtrdma/svc_rdma_transport.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> @@ -661,7 +661,7 @@ static struct svc_xprt *svc_rdma_create(struct svc_serv *serv,
>  
>  	cma_xprt = rdma_create_xprt(serv, 1);
>  	if (!cma_xprt)
> -		return ERR_PTR(ENOMEM);
> +		return ERR_PTR(-ENOMEM);
>  	xprt = &cma_xprt->sc_xprt;
>  
>  	listen_id = rdma_create_id(rdma_listen_handler, cma_xprt, RDMA_PS_TCP);
> -- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/