linux-kernel - RE: [PATCH 1/1] [PCMCIA]: add support the CF PCMCIA driver for Blackfin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 May 2008 09:36:24 +0100
From:	"Hennerich, Michael" <Michael.Hennerich@...log.com>
To:	"Russell King" <rmk+lkml@....linux.org.uk>,
	"Bryan Wu" <cooloney@...nel.org>
Cc:	<linux-pcmcia@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	"Michael Hennerich" <michael.hennerich@...log.com>
Subject: RE: [PATCH 1/1] [PCMCIA]: add support the CF PCMCIA driver for Blackfin

>-----Original Message-----
>From: Russell King [mailto:rmk@....linux.org.uk] On Behalf Of Russell
King
>Sent: Montag, 12. Mai 2008 13:37
>To: Bryan Wu
>Cc: linux-pcmcia@...ts.infradead.org; linux-kernel@...r.kernel.org;
Michael
>Hennerich
>Subject: Re: [PATCH 1/1] [PCMCIA]: add support the CF PCMCIA driver for
>Blackfin
>
>On Mon, May 12, 2008 at 06:46:40PM +0800, Bryan Wu wrote:
>> +static struct device_driver bfin_cf_driver = {
>> +	.name		= (char *) driver_name,
>> +	.bus		= &platform_bus_type,
>> +	.probe		= bfin_cf_probe,
>> +	.remove		= __devexit_p(bfin_cf_remove),
>> +	.suspend 	= pcmcia_socket_dev_suspend,
>> +	.resume 	= pcmcia_socket_dev_resume,
>> +};
>
>NAK.  All platform device drivers must be of type 'struct
platform_driver'.

Haven't looked at the code since a great while...

ACK - were going to update.

Best regards,
Michael


>
>--
>Russell King
> Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
> maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/