| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <482970DF.8020206@protei.ru> Date: Tue, 13 May 2008 14:43:43 +0400 From: Nickolay Vinogradov <nickolay@...tei.ru> To: Andrew Morton <akpm@...ux-foundation.org> CC: linux-kernel@...r.kernel.org Subject: Re: [PATCH] asm-generic/bitops/fls64.h Andrew Morton пишет: > On Sun, 04 May 2008 22:58:50 +0400 > ____________________ ______________ ____________________ <nickolay@...tei.ru> wrote: > >> bugfix in fls64 on a big endian systems(against 2.6.25). >> >> Signed-off-by: Nickolay Vinogradov <nickolay@...tei.ru> >> >> -- >> >> diff --git a/include/asm-generic/bitops/fls64.h >> b/include/asm-generic/bitops/fls64.h >> index 1b6b17c..2eedb6f 100644 >> --- a/include/asm-generic/bitops/fls64.h >> +++ b/include/asm-generic/bitops/fls64.h >> @@ -8,7 +8,7 @@ static inline int fls64(__u64 x) >> __u32 h = x >> 32; >> if (h) >> return fls(h) + 32; >> - return fls(x); >> + return fls((__u32)x); >> } >> >> #endif /* _ASM_GENERIC_BITOPS_FLS64_H_ */ > > Please describe the bug which you are fixing? > > Perhaps a more robust fix to <whatever the bug is> would be to > repair fls() so that it works correctly when passed a u64. Perhaps. Repair fls64() so that it works correctly when passed a u64. -- Nickolay Vinogradov Protei Research and Development Center St.Petersburg, 194044, Russia Tel.: +7 812 449 47 27 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists