linux-kernel - Re: Remove unused variable "cpu" from arch/x86/xen/setup.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080513120707.GE32022@elte.hu>
Date:	Tue, 13 May 2008 14:07:07 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Manish Katiyar <mkatiyar@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: Remove unused variable "cpu" from arch/x86/xen/setup.c


* Manish Katiyar <mkatiyar@...il.com> wrote:

>  Remove unused variable "cpu" from arch/x86/xen/setup.c

it's not unused:

>  void xen_enable_sysenter(void)
>  {
> -       int cpu = smp_processor_id();
>         extern void xen_sysenter_target(void);
>         /* Mask events on entry, even though they get enabled immediately */
>         static struct callback_register sysenter = {

          if (!boot_cpu_has(X86_FEATURE_SEP) ||
              HYPERVISOR_callback_op(CALLBACKOP_register, &sysenter) != 0) {
                 clear_cpu_cap(&cpu_data(cpu), X86_FEATURE_SEP);
                               ^^^^^^^^^^^^^^
                 clear_cpu_cap(&boot_cpu_data, X86_FEATURE_SEP);
          }

if it generates an unused variable warning on UP then per_cpu() needs to 
be fixed to do a (void)(cpu) to indicate use of that variable.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/