linux-kernel - Re: [PATCH 2/3] x86: janitor work in bugs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 May 2008 14:44:54 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Miklos Vajna <vmiklos@...galware.org>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 2/3] x86: janitor work in bugs.c


* Miklos Vajna <vmiklos@...galware.org> wrote:

> -		printk(KERN_EMERG "No coprocessor found and no math emulation present.\n");
> +		printk(KERN_EMERG "No coprocessor found and no math "
> +			"emulation present.\n");

generally we do not break up strings mid-stream - that makes grepping 
harder. _At most_ we do something like:

		printk(KERN_EMERG
		       "No coprocessor found and no math emulation present.\n");

> -/* trap_init() enabled FXSR and company _before_ testing for FP problems here. */
> +/* trap_init() enabled FXSR and company _before_ testing for FP problems
> + * here. */

that's not the proper multi-line comment style, this would be:

  /*
   * trap_init() enabled FXSR and company _before_ testing for
   * FP problems here.
   */

same for other places in this patch and for your next patch.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/