linux-kernel - Re: [PATCH 1/1] [MTD/MAPS] Blackfin Async Flash Maps: Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080513153441.GB18026@logfs.org>
Date:	Tue, 13 May 2008 17:34:42 +0200
From:	Jörn Engel <joern@...fs.org>
To:	Mike Frysinger <vapier.adi@...il.com>
Cc:	linux-mtd@...ts.infradead.org, Bryan Wu <cooloney@...nel.org>,
	dwmw2@...radead.org, will.newton@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] [MTD/MAPS] Blackfin Async Flash Maps: Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank

On Tue, 13 May 2008 11:15:57 -0400, Mike Frysinger wrote:
> On Tue, May 13, 2008 at 11:01 AM, Jörn Engel wrote:
> > On Tue, 13 May 2008 08:42:08 -0400, Mike Frysinger wrote:
> >  > On Tue, May 13, 2008 at 4:07 AM, Jörn Engel wrote:
> >  > > On Tue, 13 May 2008 12:38:45 +0800, Bryan Wu wrote:
> >  > >  >
> >  > >  > +#define pr_devinit(fmt, args...) ({ static const __devinitdata char __fmt[] = fmt; printk(__fmt, ## args); })
> >  > >
> >  > >  Is this still needed?
> >  >
> >  > yes
> >
> >  Can you elaborate a bit?
> 
> it's still used, therefore the definition cannot be dropped.  just
> look at the probe function.

That bit is obvious.  But why do you use pr_devinit() instead of
printk()?  What does it gain you?

Jörn

-- 
Das Aufregende am Schreiben ist es, eine Ordnung zu schaffen, wo
vorher keine existiert hat.
-- Doris Lessing
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/