linux-kernel - Re: [PATCH 3/6] RTC: SWARM I2C board initialization (#2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 May 2008 17:51:32 +0100 (BST)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Jean Delvare <khali@...ux-fr.org>
cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Atsushi Nemoto <anemo@....ocn.ne.jp>,
	David Woodhouse <dwmw2@...radead.org>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	rtc-linux@...glegroups.com, i2c@...sensors.org,
	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] RTC: SWARM I2C board initialization (#2)

Hi Jean,

> > 1. swarm-i2c.c -- SWARM I2C board setup, currently for the M41T80 chip on 
> >    the bus #1 only (there is a MAX6654 temperature sensor on the bus #0 
> >    which may be added in the future if we have a driver for that chip).
> 
> We don't have a driver yet, however the datasheet for that chip is
> publicly available and writing a driver would be easy. Or maybe just
> reuse an existing driver - from a quick look at the datasheet I suspect
> that this device is essentially compatible with the LM90 and ADM1032
> chips supported by the lm90 driver.

 True, but someone has to do that.  I feel no incentive at the moment. ;-)

> > 2. The i2c-sibyte.c BCM1250A SMBus controller driver now registers its 
> >    buses as numbered so that board setup is correctly applied.
> > 
> > Signed-off-by: Maciej W. Rozycki <macro@...ux-mips.org>
> > ---
> >  I have renamed i2c-swarm.c to swarm-i2c.c for consistency with names 
> > of other files under arch/mips/.
> 
> But you forgot to update the log message accordingly...

 I did not, unless I am missing something.

> >  Please note this patch trivially depends on
> > patch-2.6.26-rc1-20080505-swarm-core-16 -- 2/6 of this set.
> 
> OK, so I should just wait for patch 2/6 to get upstream before I add
> this one to my i2c tree?

 Either this or you can apply both and remove the local copy of the former
when it comes back from upstream.  Whatever you prefer -- it is your
choice.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/