linux-kernel - Re: 2.6.26-rc1 regression: ISA DMA broken (bisected)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4829D0E5.8050905@keyaccess.nl>
Date:	Tue, 13 May 2008 19:33:25 +0200
From:	Rene Herman <rene.herman@...access.nl>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	Bjorn Helgaas <bjorn.helgaas@...com>, Takashi Iwai <tiwai@...e.de>,
	Glauber Costa <gcosta@...hat.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Pete Clements <clem@...m.clem-digital.net>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	ALSA devel <alsa-devel@...a-project.org>
Subject: Re: 2.6.26-rc1 regression: ISA DMA broken (bisected)

On 13-05-08 19:01, Alan Cox wrote:

> On Tue, 13 May 2008 10:59:32 -0600
> Bjorn Helgaas <bjorn.helgaas@...com> wrote:
> 
>> On Friday 09 May 2008 12:06:55 am Takashi Iwai wrote:
>>> Thanks for catching it.  Yeah, the patch looks buggy.  We had an
>>> implicit assumption that dev = NULL for ISA devices that require 24bit
>>> DMA.
>> Naive question #1:  Why don't we have a struct device for these
>> ISA devices?  PNP builds a struct device with DMA_24BIT_MASK
>> for ISAPNP devices.
> 
> Because nobody has done the needed work to get all the old ISA drivers
> converted. I guess isa_device would actually be a platform_device
> wrapper ?

No, isa_device is its own thing, on its own isa_bus (*). It has a struct 
device * readily available though...

Rene

(*) drivers/base/isa.c, and explanatory changelog at:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=a5117ba7da37deb09df5eb802dace229b3fb1e9f
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/