linux-kernel - Re: [PATCH 1/1] [MTD/MAPS] Blackfin Async Flash Maps: Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080513191616.GC18026@logfs.org>
Date:	Tue, 13 May 2008 21:16:16 +0200
From:	Jörn Engel <joern@...fs.org>
To:	Mike Frysinger <vapier.adi@...il.com>
Cc:	linux-mtd@...ts.infradead.org, Bryan Wu <cooloney@...nel.org>,
	dwmw2@...radead.org, will.newton@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] [MTD/MAPS] Blackfin Async Flash Maps: Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank

On Tue, 13 May 2008 13:42:04 -0400, Mike Frysinger wrote:
> On Tue, May 13, 2008 at 11:34 AM, Jörn Engel <joern@...fs.org> wrote:
> > On Tue, 13 May 2008 12:38:45 +0800, Bryan Wu wrote:
> > > +#define pr_devinit(fmt, args...) ({ static const __devinitdata char __fmt[] = fmt; printk(__fmt, ## args); })
> >
> >  That bit is obvious.  But why do you use pr_devinit() instead of
> >  printk()?  What does it gain you?
> 
> why do we have __init and __devinit in the first place ?

Ah.  Now I finally understand what this code does.

Might be worth moving it to include/linux/kernel.h, along with
pr_init().  And watch an avalanche of janitor patches use these new
toys. :)

Jörn

-- 
Joern's library part 3:
http://inst.eecs.berkeley.edu/~cs152/fa05/handouts/clark-test.pdf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/