[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6599ad830805131432h6ea6b962v2405421c61fe88e5@mail.gmail.com>
Date: Tue, 13 May 2008 14:32:57 -0700
From: "Paul Menage" <menage@...gle.com>
To: "Andrew Morton" <akpm@...ux-foundation.org>
Cc: pj@....com, xemul@...nvz.org, balbir@...ibm.com, serue@...ibm.com,
linux-kernel@...r.kernel.org, containers@...ts.linux-foundation.org
Subject: Re: [RFC/PATCH 3/8]: CGroup Files: Move the release_agent file to use typed handlers
On Tue, May 13, 2008 at 1:08 PM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Mon, 12 May 2008 23:37:10 -0700
> menage@...gle.com wrote:
>
> > + agentbuf = kmalloc(PATH_MAX, GFP_KERNEL);
> > + if (!agentbuf)
> > + goto continue_free;
> > + strcpy(agentbuf, cgrp->root->release_agent_path);
>
> Did we need to allocate all that memory, or would kstrdup() suffice?
>
kstrdup() would be fine. Fixed.
Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists