linux-kernel - RE: [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5E701717F2B2ED4EA60F87C8AA57B7CC080BD82B@venom2>
Date:	Tue, 13 May 2008 16:46:47 -0500
From:	"Faisal Latif" <flatif@...Effect.com>
To:	"Christophe Jaillet" <christophe.jaillet@...adoo.fr>,
	"linux" <linux-kernel@...r.kernel.org>,
	"Nishi Gupta" <ngupta@...Effect.com>,
	"Glenn Streiff" <gstreiff@...Effect.com>,
	<general@...ts.openfabrics.org>
Cc:	"Roland Dreier" <rdreier@...co.com>
Subject: RE: [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset

Acked-by Faisal Latif<faisal@...effect.com>

Thanks
Faisal


> 
> From: Christophe Jaillet <christophe.jaillet@...adoo.fr>
> 
> Hi, here is a patch against linux/drivers/infiniband/hw/nes/nes_cm.c
> which :
> 
> 1) Remove an explicit memset(.., 0, ...) to a variable allocated with
> kzalloc (i.e. 'listener').
> 
> 
> Note: this patch is based on 'linux-2.6.25.tar.bz2'
> 
> Signed-off-by: Christophe Jaillet <christophe.jaillet@...adoo.fr>
> 
> ---
> 
> --- linux/drivers/infiniband/hw/nes/nes_cm.c	2008-04-17
> 04:49:44.000000000 +0200
> +++ linux/drivers/infiniband/hw/nes/nes_cm.c.cj	2008-05-12
> 23:31:24.000000000 +0200
> @@ -1587,7 +1587,6 @@ static struct nes_cm_listener *mini_cm_l
>  			return NULL;
>  		}
> 
> -		memset(listener, 0, sizeof(struct nes_cm_listener));
>  		listener->loc_addr = htonl(cm_info->loc_addr);
>  		listener->loc_port = htons(cm_info->loc_port);
>  		listener->reused_node = 0;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/