linux-kernel - RE: [PATCH 2/3] Blackfin Sports UART Driver: fix bug - the bug caused by sport overrun, use timer to flip the tty buffer in order to return from rx ISR quickly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0F1B54C89D5F954D8535DB252AF412FA01F2F0C9@chinexm1.ad.analog.com>
Date:	Tue, 13 May 2008 14:02:29 +0800
From:	"Cai, Cliff" <Cliff.Cai@...log.com>
To:	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	"Bryan Wu" <cooloney@...nel.org>
Cc:	<akpm@...ux-foundation.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/3] Blackfin Sports UART Driver: fix bug - the bug caused by sport overrun, use timer to flip the tty buffer in order to return from rx ISR quickly

I will check it later.

Thanks a lot!
Cliff Cai

-----Original Message-----
From: Alan Cox [mailto:alan@...rguk.ukuu.org.uk] 
Sent: Monday, May 12, 2008 5:49 PM
To: Bryan Wu
Cc: akpm@...ux-foundation.org; linux-kernel@...r.kernel.org; Cliff Cai;
Bryan Wu
Subject: Re: [PATCH 2/3] Blackfin Sports UART Driver: fix bug - the bug
caused by sport overrun, use timer to flip the tty buffer in order to
return from rx ISR quickly


Can you explain what the timer is for ? If you are trying to push the
tty processing out of the interrupt handler then surely schedule_work
would be sufficient. Also if you don't have tty->low_latency set the tty
layer will already do the actual processing work each timer event not in
the IRQ.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/