linux-kernel - RE: + wireless-fix-iwlwifi-unify-init-driver-flow.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C07C4589BE74A34981C3C3525EE1F80103DB4948@hasmsx412.ger.corp.intel.com>
Date:	Wed, 14 May 2008 10:34:04 +0300
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	"David Miller" <davem@...emloft.net>,
	<linux-kernel@...r.kernel.org>, <akpm@...ux-foundation.org>
Cc:	<mm-commits@...r.kernel.org>, <linville@...driver.com>,
	"Rindjunsky, Ron" <ron.rindjunsky@...el.com>,
	<sfr@...b.auug.org.au>
Subject: RE: + wireless-fix-iwlwifi-unify-init-driver-flow.patch added to -mm tree



>-----Original Message-----
>From: David Miller [mailto:davem@...emloft.net]
>Sent: Wednesday, May 14, 2008 7:39 AM
>To: linux-kernel@...r.kernel.org; akpm@...ux-foundation.org
>Cc: mm-commits@...r.kernel.org; linville@...driver.com; Rindjunsky,
Ron;
>sfr@...b.auug.org.au; Winkler, Tomas
>Subject: Re: + wireless-fix-iwlwifi-unify-init-driver-flow.patch added
to -
>mm tree
>
>From: akpm@...ux-foundation.org
>Date: Tue, 13 May 2008 21:05:50 -0700
>
>> Subject: wireless: fix "iwlwifi: unify init driver flow"
>> From: Andrew Morton <akpm@...ux-foundation.org>
>>
>> drivers/net/wireless/iwlwifi/iwl-core.c: In function
'iwlcore_init_geos':
>> drivers/net/wireless/iwlwifi/iwl-core.c:323: error: implicit
declaration
>of function 'iwlcore_init_ht_hw_capab'
>>
>> This (or something like it) should be folded into the base patch to
avoid
>> breaking bisection, please.
>>
>> Cc: Ron Rindjunsky <ron.rindjunsky@...el.com>
>> Cc: Tomas Winkler <tomas.winkler@...el.com>
>> Cc: John W. Linville <linville@...driver.com>
>> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
>> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>
>Andrew, you have to figure out what we're supposed to do here.
>
>If I "fold in the patch" to avoid breaking bisection, I have to
>completely rebase my tree screwing up everyone of my downstream
>developers.
>
>Or is this some patch I'm supposed to remember to fold in several
>months from now, to some random changeset out of thousands, when the
>merge window opens?
>
>Neither option is tenable, and the headaches of neither are
>worth it purely for the sake of bisection.
>
>My solution to the bisection problem is to wait a day before pushing
>out usually, it's a best effort thing.  I do as many sanity builds as
>I can, and we also hope that someone during that day might solve the
>problem independantly and post a fix.  That way I can fix it in my
>tree locally before the tree goes public.
>
>And I think this is the most reasonable approach.
>
>Once I push something to my public tree, quite frankly, it's the real
>deal, it's staying there, and it's a part of the permanent record.
>And therefore, we'll put fixes on top.

A patch that was sent to wireless-dev among others fixes this problem
I guess it's still stack in the Linville's queue.
http://article.gmane.org/gmane.linux.kernel.wireless.general/14339

Sorry for not catching it earlier.

Thanks
Tomas 
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/