linux-kernel - Re: [PATCH] Fix kobject_rename and !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080514025612.914a05fe.akpm@linux-foundation.org>
Date:	Wed, 14 May 2008 02:56:12 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Benjamin Thery <benjamin.thery@...l.net>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Randy Dunlap <RANDY.DUNLAP@...CLE.COM>,
	Greg KH <greg@...ah.com>, Al Viro <viro@....linux.org.uk>,
	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Daniel Lezcano <dlezcano@...ibm.com>,
	Pavel Emelyanov <xemul@...nvz.org>,
	"Serge E. Hallyn" <serue@...ibm.com>, Tejun Heo <htejun@...il.com>
Subject: Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4

On Wed, 14 May 2008 11:51:17 +0200 Benjamin Thery <benjamin.thery@...l.net> wrote:

> > uninlining sysfs_rename_dir() would be a sensible solution.
> 
> It is inlined only when CONFIG_SYSFS=n. When sysfs is enabled 
> sysfs_rename_dir() is compiled from fs/sysfs/dir.c
> 
> Uninlining it will require us to find an appropriate .c file to put it
> in: we can't put it in fs/sysfs/dir.c. It is not built if CONFIG_SYSFS 
> is disabled.

Well yes, that's the problem.  I stuck it in lib/kobject.c but ugh.

I guess we could make it a macro and quickly run away.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/