linux-kernel - Re: [PATCH] common implementation of iterative div/mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <482AE211.9040907@goop.org>
Date:	Wed, 14 May 2008 13:58:57 +0100
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Andi Kleen <andi@...stfloor.org>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Segher Boessenkool <segher@...nel.crashing.org>,
	Robert Hancock <hancockr@...w.ca>,
	Christian Kujau <lists@...dbynature.de>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	john stultz <johnstul@...ibm.com>
Subject: Re: [PATCH] common implementation of iterative div/mod

Andi Kleen wrote:
>> It's:
>> jeremy@...worth:~/hg/xen/paravirt/linux-x86_64$ gcc -v
>> Reading specs from /usr/lib/gcc/x86_64-linux/3.4.4/specs
>> Configured with: ../src/configure -v
>> --enable-languages=c,c++,java,f77,pascal,objc,ada,treelang --prefix=/usr
>> --libexecdir=/usr/lib --with-gxx-include-dir=/usr/include/c++/3.4
>> --enable-shared --with-system-zlib --enable-nls
>> --without-included-gettext --program-suffix=-3.4 --enable-__cxa_atexit
>> --enable-libstdcxx-allocator=mt --enable-clocale=gnu
>> --enable-libstdcxx-debug --enable-java-gc=boehm --enable-java-awt=gtk
>> --disable-werror x86_64-linux
>> Thread model: posix
>> gcc version 3.4.4 20050314 (prerelease) (Debian 3.4.3-13)
>>
>> I think this is still a supported compiler, isn't it?
>>     
>
> Yes. Here's a patch. You probably didn't see problems because you either
> don't have a glibc that supports the vdso or none of your programs
> gets the timezone from gettimeofday() [that is very obscure obsolete
> functionality anyways, normally it should be gotten from the disk locales]
>   

Patch looks fine to me.  I just noticed the call to memcpy by 
inspection; I haven't tried to run this.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/