linux-kernel - Re: [1/1] Export __lock_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080514143214.GA12700@2ka.mipt.ru>
Date:	Wed, 14 May 2008 18:32:15 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [1/1] Export __lock_page_killable()

Hi Alan.

On Wed, May 14, 2008 at 03:13:56PM +0100, Alan Cox (alan@...rguk.ukuu.org.uk) wrote:
> > There are users, who would like to use lock_page_killable() in modules,
> > so far there are no users in kernel, but for consistency it can be
> > exported without them.
> 
> Missing information #1: Who are the users and what are the URLs to the
> code in question

POHMELFS wants to use that in two places: one to lock page in writeback,
another one is about second part of the message - it waits for timeout
or signal or locks the page. If page can not be locked, it performs own
steps, not sleeps forever...

POHMELFS is a high performance network filesystem, homepage for interested
reader:
http://tservice.net.ru/~s0mbre/old/?section=projects&item=pohmelfs
or yesterdays mail to mail lists:
http://lwn.net/Articles/282010/

> > Not that it is particulary needed
> 
> Humm..

I copied page_waitqueue() and use wait_on_bit() logic myself.
Andrew choked with his breakfast when saw that.

> > +EXPORT_SYMBOL(__lock_page_killable);
> 
> _GPL - or better yet this could be added *when* we have an actual in tree
> user who really needs it and can show it is appropriate to export.
> That'll also save Adrian from removing it again ;)

No problem wiht GPL-only exporting, but carring it over the whole
release means no ability to build out-of-tree module.

Actually what I want to hear, is that it is needed or not at all...

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/