linux-kernel - Re: [rtc-linux] Re: [PATCH] add support for ST M41T94 SPI RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080514205308.63951ad0@i1501.lan.towertech.it>
Date:	Wed, 14 May 2008 20:53:08 +0200
From:	Alessandro Zummo <alessandro.zummo@...ertech.it>
To:	rtc-linux@...glegroups.com
Cc:	Kim.Heino@...egiga.com, linux-kernel@...r.kernel.org
Subject: Re: [rtc-linux] Re: [PATCH] add support for ST M41T94 SPI RTC

On Wed, 14 May 2008 17:23:35 +0300
"Kim B. Heino" <Kim.Heino@...egiga.com> wrote:

>
> 
> >> +struct m41t94 {
> >> +	struct rtc_device *rtc;
> >> +	u8 buf[8]; /* Burst read cmd + 7 registers */
> >> +};
> >  why are you keeping the buffer here?
> 
> rtc-max6902.c did that too... Fixed.

 d'oh! I missed it. :)
 
> >  the choice is up to you, but I'd use the century bit if there
> >  is one.
> 
> Ok, I'll add support for century bit. Again there are some other 
> rtc-drivers (like rtc-m41t80.c and rtc-ds1307.c) not using it.

 it's not mandatory, just a suggestion.

> 
> I'll wait for more comments and post a new patch tomorrow.

 ok, thanks.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/