linux-kernel - Re: [PATCH 2/3] x86: janitor work in bugs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <482A6E2B.4030806@zytor.com>
Date:	Tue, 13 May 2008 21:44:27 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Joe Perches <joe@...ches.com>
CC:	Andi Kleen <andi@...stfloor.org>,
	Miklos Vajna <vmiklos@...galware.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 2/3] x86: janitor work in bugs.c

Joe Perches wrote:
> On Tue, 2008-05-13 at 23:09 +0200, Andi Kleen wrote:
>> We had a discussion recently that wrapping printk format strings
>> is a bad idea. Don't do it please.
> 
> I don't know that there was a resolution either.
> http://lkml.org/lkml/2008/2/22/143
> 
> If there was one, there's a lot of possible changes.
> 
> $ grep -rP --include=*.[ch] "printk.*\"\s*$\s*\"" * | wc -l
> 13276
> 
> divide by 2, there are more than 6K split source line printks
> 

Perhaps a better idea would be to write a script to grep for strings.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/