linux-kernel - Re: [PATCH] OSS trident: switch from ->write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080514054707.GB6682@il.ibm.com>
Date:	Wed, 14 May 2008 08:47:08 +0300
From:	Muli Ben-Yehuda <muli@...ibm.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] OSS trident: switch from ->write_proc

Thanks Alexey, some comments below. This patch is a step in the right
direction but I'm afraid it's currently broken.

On Wed, May 14, 2008 at 01:05:44AM +0400, Alexey Dobriyan wrote:

> @@ -4441,11 +4446,8 @@ trident_probe(struct pci_dev *pci_dev, const struct pci_device_id *pci_id)
>  		/* ALi SPDIF OUT function */
>  		if (card->revision == ALI_5451_V02) {
>  			ali_setup_spdif_out(card, ALI_PCM_TO_SPDIF_OUT);
> -			res = create_proc_entry("ALi5451", 0, NULL);
> -			if (res) {
> -				res->write_proc = ali_write_proc;
> -				res->data = card;
> -			}
> +			proc_create_data("ALi5451", 0, NULL,
> +					 &ali_proc_fops, card);
>  		}
>  
>  		/* Add H/W Volume Control By Matt Wu Jul. 06, 2001 */

This is not enough--we need to also remove the proc_entry if
trident_probe() fails (see label `out_proc_fs'), which will require
checking if proc_create_data() succeeded. Please send an updated patch
or let me know and I'll take care of it.

Also, I no longer have working trident hardware---if someone else does
and can test this, please let me know. Otherwise we can should
probably go ahead and remove this old OSS driver.

Cheers,
Muli
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/