linux-kernel - Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers to fix more potential unaligned issues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200805150940.34516.oliver@neukum.org>
Date:	Thu, 15 May 2008 09:40:33 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Bryan Wu <cooloney@...nel.org>
Cc:	harvey.harrison@...il.com, david-b@...bell.net, greg@...ah.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jie Zhang <jie.zhang@...log.com>
Subject: Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers to fix more potential unaligned issues.

Am Donnerstag 15 Mai 2008 08:19:24 schrieb Bryan Wu:
> --- a/drivers/usb/host/uhci-hub.c
> +++ b/drivers/usb/host/uhci-hub.c
> @@ -253,7 +253,7 @@ static int uhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
>         switch (typeReq) {
>  
>         case GetHubStatus:
> -               *(__le32 *)buf = cpu_to_le32(0);
> +               put_unaligned_le32(0, buf);

What is supposed to make all these changes a good idea?

	Regards
		Oliver