linux-kernel - Re: [PATCH 2/9] HID: make a bus from hid code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1210842662.7025.21.camel@violet.holtmann.net>
Date:	Thu, 15 May 2008 11:11:02 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	Jiri Kosina <jkosina@...e.cz>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	anssi.hannula@...il.com, akpm@...ux-foundation.org,
	Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH 2/9] HID: make a bus from hid code

Hi Jiri,

> >> +static struct hid_driver hid_generic_bt = {
> >> +	.name = "hid-generic-bt",
> >> +	.id_table = hid_generic_bt_ids,
> >> +};
> > 
> > And this one to hidp_driver instead of hid_generic_bt.
> > 
> > Also the name "hid-generic-bt" is not okay. Call it "hidp" since that is
> > the driver name. An alternative would be "hid-bluetooth". I don't like
> > the "generic" part and we never used the shortcut "bt" in any sysfs
> > visible file.
> 
> Thanks for comments, I fixed all those except this one. The generic- word is 
> tested in the core to recognize generic drivers which bind non-blacklisted 
> devices and are handled separately. Anyway I've renamed them to 
> generic-bluetooth and generic-usb instead of hid-generic-{bt,usb}.
> 
> I think the generic word in the driver name is OK, so that one ordinary user 
> can see, my device is handled by the generic driver without special 
> processing. Would you rather see some flag or something?

actually generic-usb and generic-bluetooth sound perfectly fine to me.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/