linux-kernel - Re: [PATCH] zd1211rw: Use DMA-aware buffer for usb transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080515191647.GB17690@tuxdriver.com>
Date:	Thu, 15 May 2008 15:16:47 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
Cc:	Daniel Drake <dsd@...too.org>, Ulrich Kunitz <kune@...ne-taler.de>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] zd1211rw: Use DMA-aware buffer for usb transfer

On Fri, May 16, 2008 at 12:12:15AM +0900, Atsushi Nemoto wrote:
> The zd1211rw driver uses unaligned stack buffer for USB control
> message.  But it might cause stack corruption on non-coherent
> platform, such as MIPS.  Use DMA-aware buffers for USB transfer.
> 
> Signed-off-by: Atsushi Nemoto <anemo@....ocn.ne.jp>

Nemoto,

This looks like a reasonable fix to me.  I would prefer to see a
comment in the code indicating why you are reusing the "p" buffer
instead of simply using "ret" directly.  Also, I think the style
suggestion by Michael Buesch would make the code appear more idiomatic
as well.

Thanks!

John
-- 
John W. Linville
linville@...driver.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/