linux-kernel - Re: 2.6.26-rc2-mm1 (SCSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1210881374.21974.285.camel@chandra-ubuntu>
Date:	Thu, 15 May 2008 12:56:14 -0700
From:	Chandra Seetharaman <sekharan@...ibm.com>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, hare@...e.de,
	scsi <linux-scsi@...r.kernel.org>
Subject: Re: 2.6.26-rc2-mm1 (SCSI_DH build errors)

Hi James, Andrew,

Here is a patch to remove the automatic "select" of scsi_dh for
dm-multipath.

Sorry about the mishap.

chandra
On Thu, 2008-05-15 at 15:46 +0100, James Bottomley wrote:
> On Wed, 2008-05-14 at 14:13 -0700, Randy Dunlap wrote:
> > On Wed, 14 May 2008 01:01:29 -0700 Andrew Morton wrote:
> > 
> > > 
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.26-rc2/2.6.26-rc2-mm1/
> > 
> > SCSI_DH has some problems when CONFIG_SCSI=n:
> > 
> > drivers/built-in.o: In function `activate_path':
> > dm-mpath.c:(.text+0x18a292): undefined reference to `scsi_dh_activate'
> > drivers/built-in.o: In function `multipath_ctr':
> > dm-mpath.c:(.text+0x18a6f0): undefined reference to `scsi_dh_handler_exist'
> > make[1]: *** [.tmp_vmlinux1] Error 1
> > 
> > 
> > #
> > # SCSI device support
> > #
> > CONFIG_RAID_ATTRS=y
> > # CONFIG_SCSI is not set
> > # CONFIG_SCSI_DMA is not set
> > # CONFIG_SCSI_NETLINK is not set
> > CONFIG_SCSI_DH=y
> > CONFIG_SCSI_DH_RDAC=y
> > CONFIG_SCSI_DH_HP_SW=y
> > CONFIG_SCSI_DH_EMC=y
> 
> This is one more of those annoying selects.  The SCSI_DH Kconfig file is
> correctly dependent on SCSI:
> 
> menuconfig SCSI_DH
> 	tristate "SCSI Device Handlers"
> 	depends on SCSI
> 	default n
> 	help
> 
> but we've also got a select in md/Kconfig:
> 
> config DM_MULTIPATH
> 	tristate "Multipath target"
> 	depends on BLK_DEV_DM
> 	select SCSI_DH
> 
> Which ignores the dependency.
> 
> My best guess for fixing this is either to make the select a depends or
> just drop it altogether (after all, it's possible to have multipath on
> non-SCSI devices).
> 
> James
> 
> 

View attachment "remove_select_on_multipath" of type "text/plain" (1659 bytes)