linux-kernel - Re: [BUG] mm: bdi: export BDI attributes in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0805151247010.3019@woody.linux-foundation.org>
Date:	Thu, 15 May 2008 12:54:57 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Miklos Szeredi <miklos@...redi.hu>
cc:	ajones@...erbed.com, a.p.zijlstra@...llo.nl, mszeredi@...e.cz,
	akpm@...ux-foundation.org, kay.sievers@...y.org, greg@...ah.com,
	trond.myklebust@....uio.no, linux-kernel@...r.kernel.org
Subject: Re: [BUG] mm: bdi: export BDI attributes in sysfs



On Thu, 15 May 2008, Miklos Szeredi wrote:
> 
> Actually nothing should need protection.  The only problem AFAICS is
> that the device_create()/dev_set_drvdata() interface is racy: somebody
> can come in after the device has been created but before drvdata has
> been set, and then we are in trouble.

Well, I'm not sure that the locking should be at that level. Maybe the 
locking *should* be in the driver that does this. It may need to do other 
setup too, after all.

Of course, doing a device_create_drvdata() thing might be the right 
solution, at least part of the time. Greg?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/