linux-kernel - Re: [PULL] v9fs bug fixes and documentation updates for 2.6.26

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a4e6962a0805141943va8a9043k9ca3ff023bc6aa5@mail.gmail.com>
Date:	Wed, 14 May 2008 21:43:50 -0500
From:	"Eric Van Hensbergen" <ericvh@...il.com>
To:	"Linus Torvalds" <torvalds@...ux-foundation.org>
Cc:	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"V9FS Developers" <v9fs-developer@...ts.sourceforge.net>
Subject: Re: [PULL] v9fs bug fixes and documentation updates for 2.6.26

On Wed, May 14, 2008 at 9:40 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
>
> On Wed, 14 May 2008, Eric Van Hensbergen wrote:
>>
>> Jim Meyering (1):
>>       fs/9p/v9fs.c (v9fs_parse_options): Handle kstrdup and
>> match_strdup failure. Now that this function can fail, return an int,
>> diagnose other option-parsing failures, and adjust the sole caller:
>> (v9fs_session_init): Handle kstrdup failure. Propagate any new
>> v9fs_parse_options failure "up".
>
> Grr. Somebody isn't following the nice rules we have and that git
> encourages: make a commit message be a nice "one-line header" with the
> more complete explanation separated by an empty line (and with nice
> line-breaks etc).
>

Sorry boss.  I had a nagging feeling I was doing the wrong thing about
not diving in and fixing that comment.  Not sure where I messed up
applying the email, but if I see that sort of thing in the future I'll
edit it by hand.

>
> There are other commits that don't follow the rules, btw: you've applied
> patches from others that have the rigth Sign-off's from the authors, but
> you should sign off yourself, not just ack them. By actually taking that
> thing and committing it, you're doing more than ack'ing somebody elses
> work.
>

Sure, long term misunderstand on my part.  Thanks for clearing this
up, I'll be sure to properly sign off in the future.

          -eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/