linux-kernel - Re: [PATCH] init - fix building bug and potential buffer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080515144554.7b759b3c.akpm@linux-foundation.org>
Date:	Thu, 15 May 2008 14:45:54 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	gorcunov@...il.com, geert@...ux-m68k.org, zippel@...ux-m68k.org,
	schwab@...e.de, linux-kernel@...r.kernel.org,
	linux-m68k@...r.kernel.org
Subject: Re: [PATCH] init - fix building bug and potential buffer overflow

On Thu, 15 May 2008 14:15:38 -0700 (PDT)
Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> 
> 
> On Thu, 15 May 2008, Andrew Morton wrote:
> > 
> > (yeah, I normally parenthesise sizeof too, but this provided 80-col
> > salvation)
> 
> Why?

this, basically:

>  init/main.c |   78 +++++++++++++++++++++++++++++++----------------------------
>  1 files changed, 41 insertions(+), 37 deletions(-)

the dont-mix-bugfixes-and-cleanups mantra.

The patch looks good to me and compiles cleanly on various architectures.

> Talking about cleanups, why the *hell* does print_fn_descriptor_symbol() 
> take an "unsigned long", when every single user would want to give it a 
> pointer?

Yes, we make that mistake fairly regularly (looks at timer_list.data). 
We start out not being sure whether most callers will pass in a ulong
or a pointer and guess wrongly.

> Would somebody please want to move that cast into the macro (or better 
> yet, make it an inline function that takes a 'void *'), and remove all the 
> casts from the callers?

Would be nice.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/