linux-kernel - Re: [PATCH] list_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080514.232014.34303310.davem@davemloft.net>
Date:	Wed, 14 May 2008 23:20:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kamalesh@...ux.vnet.ibm.com
Cc:	paulmck@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, shemminger@...tta.com,
	linville@...driver.com, sri@...ibm.com, adobriyan@...il.com,
	apw@...dowen.org, balbir@...ux.vnet.ibm.com,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH] list_for_each_rcu must die: networking

From: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Date: Thu, 15 May 2008 10:56:07 +0530

> Paul E. McKenney wrote:
> > All uses of list_for_each_rcu() can be profitably replaced by the
> > easier-to-use list_for_each_entry_rcu().  This patch makes this change
> > for networking, in preparation for removing the list_for_each_rcu()
> > API entirely.
> > 
> > Updated to remove the two now-unused variables as noted by Dave Miller,
> > and also to fix my bonehead error detected by Kamalesh Babulal and
> > Alexey Dobriyan.  It now passes LTP on POWER.  And also has valid SOB.
> > Some days it just doesn't pay to get out of bed...
> 
> Hi Paul,
> 
> Thanks, the patch fixes the oops.
> 
> Tested-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
> > Acked-by: David S. Miller <davem@...emloft.net> (lkml.org/lkml/2008/4/23/448)
> > Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

I'm fine with these changes, and I acked them already.
They belong as a set with the other list_for_each_rcu killing
patches, so I'm fine with them going all together in Andrew's
tree.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/