linux-kernel - Re: [PATCH] x86: Get irq for hpet timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <482D49CF.4030902@ladisch.de>
Date:	Fri, 16 May 2008 10:46:07 +0200
From:	Clemens Ladisch <clemens@...isch.de>
To:	Kevin Hao <kexin.hao@...driver.com>
CC:	venkatesh.pallipadi@...el.com, bob.picco@...com, mingo@...hat.com,
	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: Get irq for hpet timer

Kevin Hao wrote:
> HPET timer's IRQ is 0 by default, so we have to select which irq
> will be used for these timers. We wait to set the timer's irq until
> we really turn on interrupt in order to reduce the chance of
> conflicting with some legacy device.
>
> +	for (irq = find_first_bit(&cap, HPET_MAX_IRQ); irq < HPET_MAX_IRQ;
> +		irq = find_next_bit(&cap, HPET_MAX_IRQ, 1 + irq)) {
> +		if (request_irq(irq, hpet_interrupt, irq_flags,
> +				devp->hd_name, (void *)devp)) {
> +			printk(KERN_WARNING "hpet: IRQ %d is not free\n", irq);
> +			continue;

This warning message will be output for every interrupt that is in use
by another device.  I think it would be better to postpone complaining
until after the loop, if no interrupt has been found at all.


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/