linux-kernel - Re: [PATCH] x86/xen: fix arbitrary_virt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <482D8585.90909@goop.org>
Date:	Fri, 16 May 2008 14:00:53 +0100
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Jan Beulich <jbeulich@...ell.com>, tglx@...utronix.de,
	hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/xen: fix arbitrary_virt_to_machine()

Ingo Molnar wrote:
>  	unsigned int level;
>  	pte_t *pte = lookup_address(address, &level);
> -	unsigned offset = address & PAGE_MASK;
> +	unsigned offset = address & ~PAGE_SIZE;
>   

Ah, no, you have the worst of both worlds there ;)  Should be ~PAGE_*MASK*.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/