linux-kernel - Re: thinkpad_acpi: fix possible NULL pointer dereference if kstrdup for ec_version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1210953281.30902.1253547403@webmail.messagingengine.com>
Date:	Fri, 16 May 2008 12:54:41 -0300
From:	"Henrique de Moraes Holschuh" <hmh@....eng.br>
To:	"Jan Lieskovsky" <jlieskov@...hat.com>,
	"Cyrill Gorcunov" <gorcunov@...il.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Len Brown" <len.brown@...el.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: thinkpad_acpi: fix possible NULL pointer dereference if kstrdup    
   for ec_version_str failed


On Fri, 16 May 2008 11:34:09 +0200, "Jan Lieskovsky" <jlieskov@...hat.com> said:
> There is a potential NULL pointer dereference in
> thinkpad_acpi_module_exit() -- in case,
> kstrdup for thinkpad_id.ec_version_str failed.

One can kfree(NULL) without problems.  Is there any other unprotected access to ec_version_str that I failed to see?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/