linux-kernel - Re: [patch 07/22] fat: dont call notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87prrl7rxg.fsf@duaron.myhome.or.jp>
Date:	Sat, 17 May 2008 08:25:15 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	akpm@...ux-foundation.org, hch@...radead.org,
	viro@...IV.linux.org.uk, ezk@...sunysb.edu,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 07/22] fat: dont call notify_change

Miklos Szeredi <miklos@...redi.hu> writes:

> From: Miklos Szeredi <mszeredi@...e.cz>
>
> The FAT_IOCTL_SET_ATTRIBUTES ioctl() calls notify_change() to change
> the file mode before changing the inode attributes.  Replace with
> explicit calls to security_inode_setattr(), fat_setattr() and
> fsnotify_change().
>
> This is equivalent to the original.  The reason it is needed, is that
> later in the series we move the immutable check into notify_change().
> That would break the FAT_IOCTL_SET_ATTRIBUTES ioctl, as it needs to
> perform the mode change regardless of the immutability of the file.
>
> Signed-off-by: Miklos Szeredi <mszeredi@...e.cz>
> CC: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

Don't we need to add EXPORT_SYMBOL(security_inode_setattr)? Otherwise,
looks good to me.

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/