linux-kernel - Re: [PATCH] Input: add appleir USB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 May 2008 07:44:11 +0200
From:	Tino Keitel <tino.keitel@....de>
To:	Greg KH <greg@...ah.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>, jkosina@...e.cz,
	linux-input@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: add appleir USB driver

On Thu, May 15, 2008 at 19:32:36 -0700, Greg KH wrote:
> On Fri, May 16, 2008 at 01:27:33AM +0200, Tino Keitel wrote:

[...]

> > When the appleir kernel driver is used, the IR device acts as in input
> > device, not as a HID device. LIRC has to be configured to use its
> > dev/input driver in this case. This is a generic driver to use any
> > input device as lirc device. The dev/input driver relies on the key
> > events that are generated by the kernel.
> 
> Hm, I just got a private email (for some odd reason) saying this driver
> isn't needed at all, they just add a hid quirk line.

Maybe this email came from a person who uses a distro kernel that
already included the appleir driver? IIRC at least Ubuntu did that
once. If not, I'd be interested in the detailed setup.

> Now why that hid quirk line hadn't been added for the year or so that
> the person knew about it, sure is odd to me...

There was a quirk line in the past. It was introduced by accident with
2.6.22 with commit a417a21e10831bca695b4ba9c74f4ddf5a95ac06. The commit
message only mentions keyboard and mouse devices, so I think the quirk
for the IR device was unintended.

Then I wasted several hours when I tried to use the macmini LIRC driver
with 2.6.22. The HID device that I saw came from my LCD, not from the
IR device, and I wasn't aware of the HID ignore quirk as the kernel
didn't mention it when the device was detected. That's why I also
suggested that the kernel should be more verbose about such ignore
quirks and blacklists.

In the end I found that quirk an requested to remove it. This was done
in 2.6.23-rc2.

Regards,
Tino
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/